-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix: enable TLS for HTTPS OpenTelemetry gRPC endpoints #6170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
CLA : |
|
@vyalamar, thanks for the contribution! I'm not sure what's going on with the CLA. No worries — I can see that you've accepted it, and I can override the automated check if needed. There's a formatting-related issue that the CI scripts detected. I've asked the developer who implemented the OTEL support in codex to review the PR. We should hear back from him soon. |
|
Sure thanks. I will check and update this evening. And also this needs to work on dualstack so it can work on ipv4 and ipv6 alike . Let me address that as well. |
|
I have read the CLA Document and I hereby sign the CLA. |
0f43c0e to
efc9b42
Compare
|
@etraut-openai and @haivanka — incorporated the runtime TLS wiring as discussed. |
fix: enable TLS for HTTPS OpenTelemetry gRPC endpoints
f889c4f to
6690d82
Compare
fix(otel): enable TLS for HTTPS OpenTelemetry gRPC endpoints
Context
The OpenTelemetry gRPC exporter was sending plaintext data to HTTPS endpoints because TLS was not enabled at build time and no runtime configuration existed.
Root cause
opentelemetry-otlpcrate was compiled without thetlsandtls-rootsfeaturesClientTlsConfigfor HTTPS endpoints → fallback to cleartext transmissionFix
"tls"and"tls-roots"features foropentelemetry-otlphttps://endpoints and apply:Impact
Resolves: #6153 (OpenTelemetry HTTPS plaintext issue)