-
Notifications
You must be signed in to change notification settings - Fork 6.4k
[codex][otel] support mtls configuration #6228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@haivanka could you check this branch against your endpoint? Thanks |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
etraut-openai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I admit that I have no experience with otel. If there's someone else on the team (or in the community) with more experience, you might want to ask for their review. It's probably also a good idea to wait to give community members a chance to test this branch before merging.
@apanasenko-oai it didn’t work for me. The TCP connection was established but closed immediately without a TLS handshake or any data being sent. But I think this might be an issue with my endpoint, it might not support ALPN or something like that. Here’s the patch that got encrypted otel data working for me, in case it’s of any help: |
4cb0aa6 to
0e7d644
Compare
|
@haivanka thanks for your feedback, updated branch, could you check once again, please? Thanks |
baed5b1 to
a02a830
Compare
a02a830 to
44ba8ee
Compare

fix for #6153
supports mTLS configuration and includes TLS features in the library build to enable secure HTTPS connections with custom root certificates.
grpc: https://docs.rs/tonic/0.13.1/src/tonic/transport/channel/endpoint.rs.html#63
https: https://docs.rs/reqwest/0.12.23/src/reqwest/async_impl/client.rs.html#516