Skip to content

Conversation

@lionelchg
Copy link
Contributor

@lionelchg lionelchg commented Nov 17, 2025

This closes #6748 by implementing fallback to model_family.default_reasoning_effort in reasoning_effort display of /status when no model_reasoning_effort is set in the configuration.

common/src/config_summary.rs

  • create_config_summary_entries now fills the "reasoning effort" entry with the explicit config.model_reasoning_effort when present and falls back to config.model_family.default_reasoning_effort when it is None, instead of emitting the literal string none.
  • This ensures downstream consumers such as tui/src/status/helpers.rs continue to work unchanged while automatically picking up model-family defaults when the user has not selected a reasoning effort.

tui/src/status/helpers.rs / core/src/model_family.rs

ModelFamily::default_reasoning_effort metadata is set to medium for both gpt-5*-codex and gpt-5 models following the default behaviour of the API and recommendation of the codebase:

  • per https://platform.openai.com/docs/api-reference/responses/create gpt-5 defaults to medium reasoning when no preset is passed
  • there is no mention of the preset for gpt-5.1-codex in the API docs but medium is the default setting for gpt-5.1-codex as per codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup.snap

Signed-off-by: lionelchg <lionel.cheng@hotmail.fr>
Signed-off-by: lionelchg <lionel.cheng@hotmail.fr>
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lionelchg
Copy link
Contributor Author

@etraut-openai @pakrym-oai keen to get your guidance here:

  • I think the change to config_summary.rs is really beneficial to avoid confusion in /status in any case
  • for adding explicitly medium reasoning effort there are still some tests that need to be adapted, happy to do it if you think it's worth it? If not I can just revert those changes to only keep the config_summary.rs ones in this PR :)

@etraut-openai
Copy link
Collaborator

Thanks for the change. Let's keep this small and targeted on the /status change. The other change has a higher regression risk. Once you revert that part, the /status change should be ready to merge.

@lionelchg
Copy link
Contributor Author

Just updated the branch to only include the /status change @etraut-openai :)

@etraut-openai
Copy link
Collaborator

@lionelchg, thanks for the update. The tests are now failing because the insta snapshots are incorrect. We use a tool called "insta" to snapshot the expected UI, and the tests compare the actual UI with those snapshots. You'll need to update the snapshots accordingly using cargo insta review. Once the snapshots are updated and the CI tests are green, then this should be ready to merge.

@etraut-openai etraut-openai added the needs-response Additional information is requested label Nov 18, 2025
@lionelchg
Copy link
Contributor Author

Thanks for the review @etraut-openai. Just looked at the error it seems to be a cache issue:

  • MacOS and Linux have all tests passing and when I run on my Mac cargo test -p codex-tui I do not have the error.
  • The diffs that are present for Windows all come from the commit in which I added default reasoning to medium to GPT-5.1-codex: gpt-5.1-codex (reasoning medium, summaries auto) but I already have reverted this one it seems that the Windows tests are not taking into account my last change

Let me create a brand new branch from main to confirm

@lionelchg
Copy link
Contributor Author

It did not seem to work - I do not understand why Windows would behave differently than MacOS or Linux for the display of the config in this case. Do you have any thoughts on this @etraut-openai ?

@etraut-openai etraut-openai removed the needs-response Additional information is requested label Nov 19, 2025
@etraut-openai etraut-openai merged commit a6597a9 into openai:main Nov 19, 2025
62 of 67 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong display of reasoning setting with gpt-5.1-codex and gpt-5.1

2 participants