-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Fix/correct reasoning display #6749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/correct reasoning display #6749
Conversation
Signed-off-by: lionelchg <lionel.cheng@hotmail.fr>
Signed-off-by: lionelchg <lionel.cheng@hotmail.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@etraut-openai @pakrym-oai keen to get your guidance here:
|
|
Thanks for the change. Let's keep this small and targeted on the |
|
Just updated the branch to only include the |
|
@lionelchg, thanks for the update. The tests are now failing because the insta snapshots are incorrect. We use a tool called "insta" to snapshot the expected UI, and the tests compare the actual UI with those snapshots. You'll need to update the snapshots accordingly using |
|
Thanks for the review @etraut-openai. Just looked at the error it seems to be a cache issue:
Let me create a brand new branch from |
|
It did not seem to work - I do not understand why Windows would behave differently than MacOS or Linux for the display of the config in this case. Do you have any thoughts on this @etraut-openai ? |
This closes #6748 by implementing fallback to
model_family.default_reasoning_effortinreasoning_effortdisplay of/statuswhen nomodel_reasoning_effortis set in the configuration.common/src/config_summary.rs
create_config_summary_entriesnow fills the "reasoning effort" entry with the explicitconfig.model_reasoning_effortwhen present and falls back toconfig.model_family.default_reasoning_effortwhen it isNone, instead of emitting the literal stringnone.tui/src/status/helpers.rscontinue to work unchanged while automatically picking up model-family defaults when the user has not selected a reasoning effort.tui/src/status/helpers.rs / core/src/model_family.rs
ModelFamily::default_reasoning_effortmetadata is set tomediumfor bothgpt-5*-codexandgpt-5models following the default behaviour of the API and recommendation of the codebase:gpt-5defaults tomediumreasoning when no preset is passedgpt-5.1-codexin the API docs butmediumis the default setting forgpt-5.1-codexas percodex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup.snap