Skip to content

Fix/correct reasoning display #6749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 19, 2025
Merged

Fix/correct reasoning display #6749

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f2d586d
Fallback to model_family if no model_reasoning_effort in config
lionelchg Nov 17, 2025
137690d
Add explicitely reasoning medium in gpt-5 and codex defaults
lionelchg Nov 17, 2025
831c1ab
Merge branch 'main' into fix/correct-reasoning-display
etraut-openai Nov 17, 2025
b79e6c2
Merge branch 'main' into fix/correct-reasoning-display
etraut-openai Nov 18, 2025
5bec300
Revert changing default reasoning for codex and gpt-5
lionelchg Nov 18, 2025
b7dd5d3
Merge branch 'main' into fix/correct-reasoning-display
lionelchg Nov 18, 2025
49f83d0
Merge branch 'main' into fix/correct-reasoning-display
etraut-openai Nov 18, 2025
8796d3a
Merge branch 'main' into fix/correct-reasoning-display
etraut-openai Nov 19, 2025
7126873
Merge branch 'main' into fix/correct-reasoning-display
etraut-openai Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions codex-rs/common/src/config_summary.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,12 @@ pub fn create_config_summary_entries(config: &Config) -> Vec<(&'static str, Stri
if config.model_provider.wire_api == WireApi::Responses
&& config.model_family.supports_reasoning_summaries
{
entries.push((
"reasoning effort",
config
.model_reasoning_effort
.map(|effort| effort.to_string())
.unwrap_or_else(|| "none".to_string()),
));
let reasoning_effort = config
.model_reasoning_effort
.or(config.model_family.default_reasoning_effort)
.map(|effort| effort.to_string())
.unwrap_or_else(|| "none".to_string());
entries.push(("reasoning effort", reasoning_effort));
entries.push((
"reasoning summaries",
config.model_reasoning_summary.to_string(),
Expand Down
Loading