Skip to content

Conversation

@aibrahim-oai
Copy link
Collaborator

No description provided.

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 1434 to 1437
&[
"shell_command",
"list_mcp_resources",
"list_mcp_resource_templates",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update exp-5.1 default tool expectations to unified exec

The new model family config sets all exp-* models’ shell_type to ConfigShellToolType::UnifiedExec (core/src/model_family.rs:176‑187). With unified exec, ToolsConfig registers exec_command and write_stdin instead of shell_command, but this test still asserts that exp-5.1 exposes "shell_command". As written, the test will fail and it also masks the fact that the default tool surface for experiments has changed; the expected list should reflect the unified exec tools rather than the legacy shell command.

Useful? React with 👍 / 👎.

@aibrahim-oai aibrahim-oai merged commit d5f661c into main Nov 21, 2025
24 checks passed
@aibrahim-oai aibrahim-oai deleted the enable-uexec branch November 21, 2025 21:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants