fix: path resolution bug in npx #7134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibo-openai
approved these changes
Dec 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
npx @openai/codex-shell-tool-mcp, the old code derived__dirnamefromprocess.argv[1], which points to npx’s transient wrapper script in~/.npm/_npx/134d0fb7e1a27652/node_modules/.bin/codex-shell-tool-mcp. That madevendorRootresolve to<npx cache>/vendor, so the startup checks failed with "Required binary missing" because it looked forcodex-execve-wrapperin the wrong place.By relying on the real module
__dirnameandpath.resolve(__dirname, "..", "vendor"), the package now anchors to its installed location undernode_modules/@openai/codex-shell-tool-mcp/, so the bundled binaries are found and npx launches correctly.