Skip to content

Conversation

@dylan-hurd-oai
Copy link
Collaborator

Summary

Adds test coverage for invocations of apply_patch via shell_command with heredoc, to validate behavior.

Testing

  • These are tests

@dylan-hurd-oai dylan-hurd-oai changed the title fix(apply_patch) shell_command cd parsing fix(apply_patch) tests for shell_command Dec 1, 2025
@dylan-hurd-oai dylan-hurd-oai marked this pull request as ready for review December 1, 2025 17:10
@dylan-hurd-oai dylan-hurd-oai requested review from jif-oai, pakrym-oai and pkomlev and removed request for pkomlev December 1, 2025 17:10
let bodies = vec![
sse(vec![
ev_response_created("resp-1"),
ev_function_call(call_id, "shell_command", &serde_json::to_string(&args)?),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't there a helper for this?

@dylan-hurd-oai dylan-hurd-oai force-pushed the dh--shell-command-apply-patch-tests branch from 7248b0f to d7177ad Compare December 1, 2025 21:13
@dylan-hurd-oai dylan-hurd-oai merged commit 5b25915 into main Dec 1, 2025
45 of 47 checks passed
@dylan-hurd-oai dylan-hurd-oai deleted the dh--shell-command-apply-patch-tests branch December 1, 2025 23:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants