feat: add warning message for the model #7445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibrahim-oai
reviewed
Dec 1, 2025
aibrahim-oai
reviewed
Dec 1, 2025
| pub(crate) const MAX_UNIFIED_EXEC_SESSIONS: usize = 64; | ||
|
|
||
| // Send a warning message to the models when it reaches this number of sessions. | ||
| pub(crate) const WARNING_UNIFIED_EXEC_SESSIONS: usize = 60; |
Collaborator
There was a problem hiding this comment.
Shouldn't we use MAX_UNIFIED_EXEC_SESSIONS? or something relative to it?
Collaborator
Author
There was a problem hiding this comment.
We want something slightly lower on purpose. To avoid having to prune
Collaborator
There was a problem hiding this comment.
Let's use it relative to it at least so we have only one magic number?
Collaborator
Author
There was a problem hiding this comment.
Then we need a relative factor so same thing. I kind of like the idea of soft and hard limits
Collaborator
Author
There was a problem hiding this comment.
I need to merge to move on but happy to discuss this mater further and I can do a follow-up PR if you don't agree
# Conflicts: # codex-rs/core/src/features.rs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning message as a user turn to the model if the model does not behave as expected (here, for example, if the model opens too many
unified_execsessions)