fix: add ts number annotations for app-server v2 types #7492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jif-oai
approved these changes
Dec 2, 2025
| pub struct CommandExecParams { | ||
| pub command: Vec<String>, | ||
| #[ts(type = "number | null")] | ||
| pub timeout_ms: Option<u64>, |
Contributor
Author
There was a problem hiding this comment.
sounds good, let me update
Contributor
Author
There was a problem hiding this comment.
why, out of curiosity?
Collaborator
There was a problem hiding this comment.
Having a negative timeout is invalid: I don't think we should change this one.
gpeal
approved these changes
Dec 2, 2025
owenlin0
force-pushed
the
owen/add_ts_number_annotations
branch
from
8d82a73 to
e714413
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be more ergonomic to work with in Typescript.