fix: Features should be immutable over the lifetime of a session/thread #7540
+26
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
features: Featureswas defined onstruct SessionConfiguration, which is commonly owned bySessionState, which is in turn owned bySession.Though I do not believe that
Featuresshould be allowed to be modified over the course of a session (if the feature state is not invariant, it makes it harder to reason about), which argues that it should live onSessionrather thanSessionStateorSessionConfiguration.This PR moves
FeaturestoSessionand updates all call sites. It appears the only place we were mutatingFeatureswas:codex/codex-rs/core/src/tasks/review.rs
Lines 86 to 89 in 3ef76ff
Note this change also means it is no longer an
asynccall to check the state of a feature, eliminating the possibility of a TOCTTOU error between checking the state of a feature and acting on it:codex/codex-rs/core/src/codex.rs
Lines 1069 to 1076 in 3ef76ff