[app-server] make file_path for config optional
#7560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celia-oai
force-pushed
the
dev/cc/config
branch
2 times, most recently
from
657ec9f to
894dcfe
Compare
celia-oai
changed the title
file_path for config optional
owenlin0
approved these changes
Dec 4, 2025
Contributor
owenlin0
left a comment
owenlin0
left a comment
There was a problem hiding this comment.
IMO let's:
- add a docstring to file_path to document that if unspecified, it will default to the user's config.toml?
- add
pub file_path: Stringto ConfigWriteResponse, so that the client has visibility to which file was written to
thoughts? otherwise looks good
celia-oai
force-pushed
the
dev/cc/config
branch
from
894dcfe to
00f7da5
Compare
celia-oai
force-pushed
the
dev/cc/config
branch
from
e2c80cd to
292b515
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are writing to config using
config/value/writeorconfig/batchWrite, it always require aconfig/readbefore it right now in order to get the correct file path to write to. make this optional so we read from the default user config file if this is not passed in.