Workspace lints and disallow unwrap #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoens-openai
force-pushed
the
dev/jcoens/reduce_panics
branch
3 times, most recently
from
3fcedb5 to
1d43cca
Compare
bolinfest
approved these changes
May 8, 2025
Collaborator
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
Thanks! This is a good rule to follow.
codex-rs/apply-patch/src/lib.rs
Outdated
Collaborator
There was a problem hiding this comment.
Is this necessary for every mod tests?
Contributor
Author
There was a problem hiding this comment.
If we want tests to use unwrap then yes
Collaborator
There was a problem hiding this comment.
I see: I guess I would have hoped/expected the lint to disable for #[cfg(test)] by default, but I can live with this!
codex-rs/apply-patch/src/lib.rs
Outdated
Collaborator
There was a problem hiding this comment.
Would with_context from anyhow work here?
codex-rs/apply-patch/src/lib.rs
Outdated
Collaborator
There was a problem hiding this comment.
Not sure about this comment? Intentionally or written by Codex?
Contributor
Author
There was a problem hiding this comment.
Ha, yes, leftover model comment
jcoens-openai
force-pushed
the
dev/jcoens/reduce_panics
branch
from
1d43cca to
54b2728
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets submodules to use workspace lints. Added denying unwrap as a workspace level lint, which found a couple of cases where we could have propagated errors. Also manually labeled ones that were fine by my eye.