Skip to content

Conversation

@viyatb-oai
Copy link
Contributor

@viyatb-oai viyatb-oai commented Jan 7, 2026

Summary

  • Upgrade Rust toolchain used by CI to 1.92.0.
  • Address new clippy derivable_impls warnings by deriving Default for enums across protocol, core, backend openapi models, and windows-sandbox setup.
  • Tidy up related test/config behavior (originator header handling, env override cleanup) and remove a now-unused assignment in TUI/TUI2 render layout.

Testing

  • just fmt
  • just fix -p codex-tui
  • just fix -p codex-tui2
  • just fix -p codex-windows-sandbox
  • cargo test -p codex-tui
  • cargo test -p codex-tui2
  • cargo test -p codex-windows-sandbox
  • cargo test -p codex-core --test all
  • cargo test -p codex-app-server --test all
  • cargo test -p codex-mcp-server --test all
  • cargo test --all-features

@viyatb-oai viyatb-oai changed the title Bump Rust toolchain to 1.92 across codex-rs and CI chore: upgrade to Rust 1.92.0 Jan 7, 2026
Copy link
Collaborator

@joshka-oai joshka-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General approval - unsure what the mentioned changes are about here. Can you revert these and check the errors?

@viyatb-oai viyatb-oai merged commit f89a40a into main Jan 16, 2026
32 checks passed
@viyatb-oai viyatb-oai deleted the codex/upgrade-codex-rs-to-rust-1.92.0 branch January 16, 2026 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants