Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
joshka-oai
left a comment
joshka-oai
left a comment
There was a problem hiding this comment.
Code looks good.
I think we should probably do this automatically on clear / delete line rather than explicitly like this though. Chatting internally on it.
| @@ -318,6 +334,69 @@ impl ChatComposer { | |||
| self.sync_popups(); | |||
| } | |||
|
|
|||
| /// Replace the composer content with text, rebuilding attachment elements. | |||
| pub(crate) fn apply_external_edit(&mut self, text: String) { | |||
There was a problem hiding this comment.
This method's name is at a high level of abstraction, while the implementation drops to low level. There's nothing in between that binds the overall intent to the actual implementation detail. Add an overview of what this method does to help validate the intention of the logic inside this method aligns with what it actually does, as well as probably some inline comments helping make that clear. Codex is pretty good at rewriting this sort of thing to fit that criteria.
etraut-openai
added
accessibility
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
3 participants
Add the QOL feature to "stash" a prompt locally, which is auto-popped on next submit.
Stash is triggered by the hotkey
ctrl + s. The stack has depth 1 and overrides on multiple stashes.Test Plan
Added unit tests. Tested locally for tui and tui2.
I was unable to fully e2e test image stash pops due to the way openai configures terminal permissions for local dev, but the image pointer is successfully popped.