add generated jsonschema for config.toml #8956
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e888413dc6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08b477fa14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
That's cool. We should publish it to some standard directories (and have a gh job for this)
@joshka-oai had some thoughts on this I think
|
Yep. Publish a small pointer file to Json-schema.org, then publish this file to our website so we can easily update it in each release. We also need to add a small comment in our config files to point at the schema location (as we use config.toml rather than a more specific name like codex.toml which can be auto detected). |
|
In terms of publishing artifacts, that should be done as part of |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f59e49902f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sayan-oai
force-pushed
the
dev/sayan/config-jsonschema
branch
from
c6e0bb9 to
1529cf4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1529cf44c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 123d2333df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sayan-oai
force-pushed
the
dev/sayan/config-jsonschema
branch
from
0c40b7b to
13dd199
Compare
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
Just some small things, but this LGTM!
sayan-oai
force-pushed
the
dev/sayan/config-jsonschema
branch
from
13dd199 to
51e7c7d
Compare
What
Add JSON Schema generation for
config.toml, with checked‑indocs/config.schema.json. We can move the schema elsewhere if preferred (and host it if there's demand).Add fixture test to prevent drift and
just write-config-schemato regenerate on schema changes.Generate MCP config schema from
RawMcpServerConfiginstead ofMcpServerConfigbecause that is the runtime type used for deserialization.Populate feature flag values into generated schema so they can be autocompleted.
Tests
Added tests + regenerate script to prevent drift. Tested autocompletions using generated jsonschema locally with Even Better TOML.
jsonschema.mov