Assemble sandbox/approval/network prompts dynamically #8961

aibrahim-oai · 2026-01-09T08:30:42Z

Add a single builder for developer permissions messaging that accepts SandboxPolicy and approval policy. This builder now drives the developer “permissions” message that’s injected at session start and any time sandbox/approval settings change.
Trim EnvironmentContext to only include cwd, writable roots, and shell; removed sandbox/approval/network duplication and adjusted XML serialization and tests accordingly.

Follow-up: adding a config value to replace the developer permissions message for custom sandboxes.

aibrahim-oai · 2026-01-09T08:35:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a40e5a755a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/protocol/src/models.rs

aibrahim-oai · 2026-01-09T20:28:25Z

@codex review this and make sure tests changes didn't invalidate tests original intentions

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2240249141

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/tests/suite/prompt_caching.rs

aibrahim-oai · 2026-01-09T20:47:05Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc5c68019b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/protocol/src/prompts/permissions/approval_policy/on_request.md

aibrahim-oai · 2026-01-10T17:18:35Z

@codex do we append a new permission message on resume and fork next to the older messages? If yes, add an integration test. If not, change behavior and add integration test.

chatgpt-codex-connector · 2026-01-10T17:46:21Z

Summary

Appended a fresh permissions developer message when resuming or forking sessions and persisted it alongside reconstructed history for the new turn context. codex-rs/core/src/codex.rsL836-L861
Updated resume/fork history expectations and expanded permissions integration coverage to include a forked-session case and the extra permissions message count. codex-rs/core/src/codex.rsL2961-L3079 codex-rs/core/tests/suite/permissions_messages.rsL182-L327

Testing

✅ /root/.cargo/bin/just fmt
✅ /root/.cargo/bin/just fix -p codex-core
❌ cargo test -p codex-core (failed: default_client::tests::test_create_client_sets_default_headers; exec::tests::kill_child_process_group_kills_grandchildren_on_timeout; shell_snapshot::tests::linux_sh_snapshot_includes_sections; models_manager::manager::tests::refresh_available_models_{drops_removed_remote_models,refetches_when_cache_stale,sorts_and_marks_default,uses_cache_when_fresh}; unified_exec::tests::{reusing_completed_process_returns_unknown_process,multi_unified_exec_sessions})

View task →

dylan-hurd-oai

Some small comments but mostly LGTM!

dylan-hurd-oai · 2026-01-12T21:36:20Z

codex-rs/core/src/codex.rs

+            )
+            .into(),
+        )
+    }


(non-blocking) Should we move this out of codex.rs? Either into environment_context.rs or a new file

it's on turn context unfortunately

codex-rs/core/src/codex.rs

dylan-hurd-oai · 2026-01-12T22:27:28Z

codex-rs/protocol/src/models.rs

+    text: String,
+}
+
+const APPROVAL_POLICY_NEVER: &str = include_str!("prompts/permissions/approval_policy/never.md");


Agree w/ pavel. Is the plan to start using DeveloperInstructions as a serialized struct?

codex-rs/protocol/src/models.rs

aibrahim-oai added 2 commits January 9, 2026 00:30

dynamic permissions

6892b00

dynamic permissions

7547a01

aibrahim-oai changed the title ~~dynamic permissions~~ WIP: dynamic permissions Jan 9, 2026

dynamic permissions

a40e5a7

chatgpt-codex-connector bot reviewed Jan 9, 2026

View reviewed changes

codex-rs/protocol/src/models.rs Outdated Show resolved Hide resolved

aibrahim-oai added 12 commits January 9, 2026 10:35

delete sandbox from prompts

a42d9f1

prompts

3a35006

tests

5f8dc36

writable roots

ef69969

writable roots

495b88b

fix

6a1144e

tests

4fd7486

tests

2219742

tests

3812f0e

tests

93df546

writable roots

1e7d95b

writable roots

2240249

aibrahim-oai added 2 commits January 9, 2026 12:29

writable roots

8a66fa9

writable roots

15d60c6

chatgpt-codex-connector bot reviewed Jan 9, 2026

View reviewed changes

codex-rs/core/tests/suite/prompt_caching.rs Outdated Show resolved Hide resolved

clone

fc5c680

chatgpt-codex-connector bot reviewed Jan 9, 2026

View reviewed changes

codex-rs/protocol/src/prompts/permissions/approval_policy/on_request.md Outdated Show resolved Hide resolved

aibrahim-oai added 5 commits January 9, 2026 13:04

move

bbf15f0

move

3dec2ad

move

ca9b6af

move

c39587c

fmt

3ca037f

aibrahim-oai added 10 commits January 9, 2026 16:05

tag

f55baf8

xml

eaa7a71

tests

300efe6

tests

d0d716f

tag

9b24f82

tag

a6b3753

tests

92c54f9

prompt improvments

583887c

prompt

3e06f38

tests

c412512

aibrahim-oai added 3 commits January 10, 2026 23:44

tests

ab3b246

Fix permissions message test expectations

74a8a21

wrtiable roots

ef60b19

aibrahim-oai force-pushed the dynamic/permissions/instructions branch from 12d2829 to ef60b19 Compare January 12, 2026 19:57

aibrahim-oai added 6 commits January 12, 2026 12:11

fix

cb46d1d

fix

2c2562f

tests

e58bae1

lint

5c98302

lint

c14e99a

lint

7338c1a

dylan-hurd-oai reviewed Jan 12, 2026

View reviewed changes

dylan-hurd-oai approved these changes Jan 12, 2026

View reviewed changes

lint

441ddf4

aibrahim-oai enabled auto-merge (squash) January 12, 2026 22:57

dylan-hurd-oai mentioned this pull request Jan 12, 2026

fix(context) update environment_context on resume #8990

Closed

2 tasks

aibrahim-oai merged commit 87f7226 into main Jan 12, 2026
32 checks passed

aibrahim-oai deleted the dynamic/permissions/instructions branch January 12, 2026 23:13

github-actions bot locked and limited conversation to collaborators Jan 12, 2026

Assemble sandbox/approval/network prompts dynamically #8961

Assemble sandbox/approval/network prompts dynamically #8961

Uh oh!

Conversation

aibrahim-oai commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aibrahim-oai commented Jan 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aibrahim-oai commented Jan 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aibrahim-oai commented Jan 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aibrahim-oai commented Jan 10, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 10, 2026

Uh oh!

dylan-hurd-oai left a comment

Choose a reason for hiding this comment

Uh oh!

dylan-hurd-oai Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

aibrahim-oai Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dylan-hurd-oai Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aibrahim-oai commented Jan 9, 2026 •

edited

Loading