-
Notifications
You must be signed in to change notification settings - Fork 7.4k
tui: allow forward navigation in backtrack preview #9059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Thanks @etraut for resolving conflicts, much appreciated. I pushed a small follow-up commit on top to fix the forward-step highlight path and keep the WSL helper import gated under |
|
Let’s split this PR into two parts. The WSL-related issue is orthogonal to the Esc / backtrack behavior and would be better addressed in a separate change. Keeping them together makes the scope harder to reason about and review, and they likely have different root causes and fixes. If we can isolate the backtrack navigation changes here and handle the WSL behavior independently, that will make both paths clearer and easier to validate. |
When the backtrack preview is armed (Esc), allow moving to newer user messages with Right arrow, and to older messages with Esc/Left arrow, before confirming with Enter. Also updates the transcript overlay footer hints and tests.
Ensure the forward step in transcript backtrack preview only updates the highlight selection.
2b50b42 to
0d0ac23
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
joshka-oai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the PR (resolved the merge conclict and will ship)
Fixes #9058
Summary
When the transcript backtrack preview is armed (press
Esc), allow navigating to newer user messages with the→arrow, in addition to navigating backwards withEsc/←, before confirming withEnter.Changes
Esc/←steps to older user messages,→steps to newer ones,Enteredits the selected message (clamped at bounds, no wrap-around).esc/←,→, andenterwhen a message is highlighted.Related
Testing
just fmtjust fix -p codex-tuijust fix -p codex-tui2cargo test -p codex-tui app_backtrack::cargo test -p codex-tui pager_overlay::cargo test -p codex-tui2 app_backtrack::cargo test -p codex-tui2 pager_overlay::