feat: add auto refresh on thread listeners #9105
Merged
+114
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # codex-rs/app-server/tests/suite/send_message.rs # codex-rs/core/src/thread_manager.rs
celia-oai
approved these changes
Jan 13, 2026
codex-rs/app-server/tests/suite/codex_message_processor_flow.rs
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 969e384b15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
gt-oai
approved these changes
Jan 14, 2026
| } | ||
|
|
||
| /// Ensure we have a listener for thread_id | ||
| pub(crate) async fn ensure_thread_listener(&mut self, thread_id: ThreadId) { |
Contributor
There was a problem hiding this comment.
It's a bit of a smell that this is called "ensure" if all it does is warn on error. Perhaps we could better comment under what circumstances attach_conversation_listener fails?
Collaborator
Author
There was a problem hiding this comment.
In theory in should never fail in this scenario but will do
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in the scope of multi-agent work.
An agent (=thread) can now spawn other agents. Those other agents are not attached to any clients. We need a way to make sure that the clients are aware of the new threads to look at (for approval for example). This PR adds a channel to the
ThreadManagerthat pushes the ID of those newly created agents such that the client (here the app-server) can also subscribe to those ones.