Skip to content

Conversation

@charley-oai
Copy link
Collaborator

Sending a message during /review interrupts the review, whereas during normal operation, sending a message while the agent is running will queue the message. This is unexpected behavior, and since /review usually takes a while, it takes away a potentially useful operation.

Summary

  • Treat review mode as an active task for message queuing so inputs don’t inject into the running review turn.
  • Prevents user submissions from rendering immediately in the transcript while the review continues streaming.
  • Keeps review UX consistent with normal “task running” behavior and avoids accidental interrupt/replacement.

Notes

  • This change only affects UI queuing logic; core review flow and task lifecycle remain unchanged.

@charley-oai charley-oai force-pushed the properly-queue-messages-during-/review branch from f9e7130 to af6ff66 Compare January 13, 2026 00:39

fn queue_user_message(&mut self, user_message: UserMessage) {
if self.bottom_pane.is_task_running() {
if self.bottom_pane.is_task_running() || self.is_review_mode {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a snapshot

@charley-oai charley-oai merged commit 57ba758 into main Jan 13, 2026
51 of 53 checks passed
@charley-oai charley-oai deleted the properly-queue-messages-during-/review branch January 13, 2026 19:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants