fix: drop session span at end of the session #9126
Merged
+9
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanasenko-oai
force-pushed
the
anton_panasenko_fix_tracing
branch
from
b65b3d6 to
8e705ec
Compare
jif-oai
approved these changes
Jan 13, 2026
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
Approved to unblock but we should resolve this Arc<Mutex<Option<Span>>> before merging
codex-rs/otel/src/lib.rs
Outdated
| pub struct OtelManager { | ||
| pub(crate) metadata: OtelEventMetadata, | ||
| pub(crate) session_span: Span, | ||
| pub(crate) session_span: Arc<Mutex<Option<Span>>>, |
Collaborator
There was a problem hiding this comment.
This looks pretty bad to me. The Mutex will block the runner and in general this kind of object look like a smell.
Could you at least use a RwLock? (and I think we can drop the Option as Span::none() should be available
Collaborator
Author
There was a problem hiding this comment.
remove it at all to simplify whole process.
apanasenko-oai
force-pushed
the
anton_panasenko_fix_tracing
branch
from
8e705ec to
47ebeb1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.