chore: clamp min yield time for empty write_stdin #9156
Merged
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
reviewed
Jan 14, 2026
| let max_tokens = resolve_max_tokens(request.max_output_tokens); | ||
| let yield_time_ms = clamp_yield_time(request.yield_time_ms); | ||
| let yield_time_ms = { | ||
| let time_ms = clamp_yield_time(request.yield_time_ms); |
Collaborator
There was a problem hiding this comment.
do we need to pre clamp before the condition?
Collaborator
Author
There was a problem hiding this comment.
This is cheap and my logic was: if one day we add some custom logic in it, might be worth it to keep. But this is mostly because it's basically free
pakrym-oai
approved these changes
Jan 14, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After evals, 0 impact on performance