Improve UI spacing for queued messages #9162
Conversation
charley-oai
force-pushed
the
improve-spacing-for-queued-messages
branch
4 times, most recently
from
d123ea0 to
4b2fbc2
Compare
|
@codex review this |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
joshka-oai
left a comment
joshka-oai
left a comment
There was a problem hiding this comment.
Looks like there is an unrelated paste-burst change in this (or at least I don't see how it's directly related). I'm guessing that there was a transient / flakey test that codex fixed. Consider removing / pushing to another PR (not a big deal, but maybe worth noting why it changed).
Otherwise LGTM
| --- | ||
| • Working (0s • esc to interrupt) | ||
|
|
||
| ↳ Queued follow-up question |
There was a problem hiding this comment.
(non blocking) Is it worth dropping the ↳ character here? @edward-bayes
charley-oai
force-pushed
the
improve-spacing-for-queued-messages
branch
2 times, most recently
from
a9636bc to
2fd3b36
Compare
|
@codex review this |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Despite good spacing between queued messages and assistant message text:
Codex has confusing spacing between queued messages and shimmering status text (making the queued message seem like a sub-item of the shimmering status text)
This PR changes the spacing between the queued message(s) and shimmering status text to make it less confusing:
While working on the status/queued spacing change, we noticed two paste‑burst tests were timing‑sensitive and could fail
on slower CI. We added a small test‑only helper to keep the paste‑burst state active and refreshed during these tests. This
removes dependence on tight timing and makes the tests deterministic without affecting runtime behavior.