[codex-tui] exit when terminal is dumb #9293
Merged
+60
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
jmickey-oai
force-pushed
the
jmickey/fix-dumb
branch
from
82ae0ee to
e4a02f8
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
joshka-oai
force-pushed
the
jmickey/fix-dumb
branch
from
e4a02f8 to
d8bdb84
Compare
joshka-oai
approved these changes
Jan 20, 2026
Collaborator
joshka-oai
left a comment
joshka-oai
left a comment
There was a problem hiding this comment.
Added some bits to this:
- confirmation prompt to continue anyway
- added dumb to the term detection code
Using terminal with TERM=dumb specifically mean that TUIs and the like don't work. Ensure that codex doesn't run in these environments and exit with odd errors like crossterm's "Error: The cursor position could not be read within a normal duration"
Route TERM=dumb through terminal detection and user agent tokens. Warn and prompt before starting the TUI, falling back to a fatal AppExitInfo when no TTY is available for confirmation. Add AppExitInfo::fatal for consistent fatal exits.
joshka-oai
force-pushed
the
jmickey/fix-dumb
branch
from
d8bdb84 to
ba71daa
Compare
Contributor
Author
|
thanks for carrying this forward with a far better change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using terminal with TERM=dumb specifically mean that TUIs and the like don't work. Ensure that codex doesn't run in these environments and exit with odd errors like crossterm's "Error: The cursor position could not be read within a normal duration"