-
Notifications
You must be signed in to change notification settings - Fork 7.4k
fix(windows-sandbox): remove request files after read #9316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(windows-sandbox): remove request files after read #9316
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3b8a8d481
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Updated the test to use |
…-request-file-cleanup
…-cleanup' into fix/windows-sandbox-request-file-cleanup
|
Thanks @etraut-openai for the codex review. I just merged the latest main into this branch to clear the out-of-date warning, which re-triggered CI. In prior runs, the only failures were Bazel (experimental) due to missing API keys in the fork (BEP upload). Happy to rerun or adjust if you need anything. |
iceweasel-oai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this!
Summary
Testing
cargo test -p codex-windows-sandbox(Windows)Fixes #9315