Skip to content

Conversation

@MaxMiksa
Copy link
Contributor

Summary

  • Remove elevated runner request files after read (best-effort cleanup on errors)
  • Add a unit test to cover request file lifecycle

Testing

  • cargo test -p codex-windows-sandbox (Windows)

Fixes #9315

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@MaxMiksa
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 16, 2026
@etraut-openai
Copy link
Collaborator

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d3b8a8d481

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@MaxMiksa
Copy link
Contributor Author

Updated the test to use pretty_assertions::assert_eq as suggested and re-ran cargo test -p codex-windows-sandbox on Windows (pass).

@MaxMiksa
Copy link
Contributor Author

Thanks @etraut-openai for the codex review. I just merged the latest main into this branch to clear the out-of-date warning, which re-triggered CI. In prior runs, the only failures were Bazel (experimental) due to missing API keys in the fork (BEP upload). Happy to rerun or adjust if you need anything.

Copy link
Collaborator

@iceweasel-oai iceweasel-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@etraut-openai etraut-openai merged commit e2bd931 into openai:main Jan 24, 2026
26 of 32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows sandbox: elevated runner request files are left on disk

3 participants