feat: timer total turn metrics #9382
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45fe79c462
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let timer = turn_context | ||
| .client | ||
| .get_otel_manager() | ||
| .start_timer("codex.turn.e2e_duration_ms", &[]) | ||
| .ok(); |
There was a problem hiding this comment.
The codex.turn.e2e_duration_ms timer is stored in RunningTask and will be dropped as soon as on_task_finished removes the task from ActiveTurn, which happens before close_unified_exec_processes() and before the TurnComplete event is sent. This means the “e2e” metric under-reports whenever process teardown or event dispatch is slow, and it also makes completion timings inconsistent with the abort path (where the timer survives until after the abort event is sent). If you want the metric to reflect user‑visible turn completion, keep the timer alive until after send_event/cleanup or record explicitly at that point.
Useful? React with 👍 / 👎.
No description provided.