Expose collaboration presets #9421
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecc46e11c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fn plan_preset() -> CollaborationMode { | ||
| CollaborationMode::Plan(Settings { | ||
| model: "gpt-5.2-codex".to_string(), | ||
| reasoning_effort: Some(ReasoningEffort::Medium), |
There was a problem hiding this comment.
The presets returned by collaborationMode/list hardcode gpt-5.2-codex, so a user who has changed their default model (e.g., via setDefaultModel) will still receive presets that point to gpt-5.2-codex. Any client that applies the preset wholesale will silently override the user’s chosen model, which is inconsistent with the rest of the server configuration flow and the comment in the manager about using the configured model. Consider deriving the preset model from the current config/default model instead of hardcoding it.
Useful? React with 👍 / 👎.
Clarify the collaboration mode list contract so defaults and ordering are explicit. This is documentation-only and does not change behavior.
joshka-oai
force-pushed
the
collaporation/presets
branch
from
27b0f3e to
a1dafae
Compare
|
Pushed a fix for the formatting / small extra docs on the tests based on codex telling me that this would break if the API call changed. |
Expose collaboration presets for clients