chore(instructions) Remove unread SessionMeta.instructions field #9423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
instructionsfield from the session metadata to simplify SessionMeta and stop propagating transient instruction text through the rollout recorder API. This was only saving user_instructions, and was never being read.Testing
just fmtwhich completed successfully.just fix -p codex-protocol,just fix -p codex-core,just fix -p codex-app-server,just fix -p codex-tui, andjust fix -p codex-tui2which completed (Clippy fixes applied) as part of verification.cargo test -p codex-protocolwhich passed (28 tests).cargo test -p codex-corewhich showed failures in a small set of tests (not caused by the protocol type change directly):default_client::tests::test_create_client_sets_default_headers, severalmodels_manager::manager::tests::refresh_available_models_*, andshell_snapshot::tests::linux_sh_snapshot_includes_sections(these tests failed in this CI run).cargo test -p codex-app-serverwhich reported several failing integration tests (includingsuite::codex_message_processor_flow::test_codex_jsonrpc_conversation_flow,suite::output_schema::send_user_turn_*, andsuite::user_agent::get_user_agent_returns_current_codex_user_agent).cargo test -p codex-tuiandcargo test -p codex-tui2were attempted but aborted due to disk space exhaustion (No space left on device).Codex Task