TUI: collaboration mode UX + always submit UserTurn when enabled
#9461
Conversation
aibrahim-oai
changed the title
aibrahim-oai
changed the title
UserTurn when enabled
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0e9045b90
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
That "looks" ok but the changes in the snapshot worries me a bit
Also, "collab" is used everything in the code for as the "code name" of the multi-agent capabilities, I fear this becomes quickly messy if we have the same name for 2 totally different things
...ne/snapshots/codex_tui__bottom_pane__chat_composer__tests__footer_mode_shortcut_overlay.snap
Outdated
Show resolved
Hide resolved
| @@ -1,6 +1,5 @@ | |||
| --- | |||
| source: tui/src/bottom_pane/chat_composer.rs | |||
| assertion_line: 2116 | |||
There was a problem hiding this comment.
ooc, how is this related?
There was a problem hiding this comment.
fixed. this happen when snapshots changes and then change back automatically
...om_pane/snapshots/codex_tui__bottom_pane__footer__tests__footer_shortcuts_shift_and_esc.snap
Show resolved
Hide resolved
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5433b7d56e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub(crate) fn show_footer_flash(&mut self, line: Line<'static>, duration: Duration) { | ||
| let expires_at = Instant::now() | ||
| .checked_add(duration) | ||
| .unwrap_or_else(Instant::now); | ||
| self.footer_flash = Some(FooterFlash { line, expires_at }); |
There was a problem hiding this comment.
The bottom-pane AGENTS.md (codex-rs/tui/src/bottom_pane/AGENTS.md) requires updating the chat-composer module docs and docs/tui-chat-composer.md whenever the ChatComposer state machine changes. This commit introduces new ChatComposer state/behavior (footer flash timing and collaboration-mode command handling) but doesn’t update those docs, so the documented behavior will now be stale and harder to maintain. Please update the module docs and docs/tui-chat-composer.md to reflect the new footer flash and collaboration-mode command flow.
Useful? React with 👍 / 👎.
Feature::CollaborationModes; existing behavior remains unchanged when disabled.Shift+Tabcycles modes while idle (no task running, no modal/popup)./collabcycles;/collab <plan|pair|pp|execute|exec>sets explicitly.Shift+Tab“to change mode”./statusshows “Collaboration mode”.Op::UserTurnand always includescollaboration_mode: Some(...)(default Pair Programming).tui/src/collaboration_modes.rs(selection enum/cycle,/collabparsing, resolve toCollaborationMode, footer flash line).resolve_mode_or_fallbacksynthesizes aCollaborationModewhen presets are missing (uses current model + reasoning effort; nodeveloper_instructions) to avoid core falling back toCustom.Op::UserTurn.