feat: close all threads in /new
#9478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gt-oai
approved these changes
Jan 19, 2026
| /// Closes all threads open in this ThreadManager | ||
| pub async fn remove_and_close_all_threads(&self) -> CodexResult<()> { | ||
| for thread in self.state.threads.read().await.values() { | ||
| thread.submit(Op::Shutdown).await?; |
Contributor
There was a problem hiding this comment.
Will this error contain any info about which thread failed to shutdown?
Collaborator
Author
There was a problem hiding this comment.
Nope :/ this basically should only happen when the thread is already gone
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.