Skip to content

Conversation

@charley-oai
Copy link
Collaborator

@charley-oai charley-oai commented Jan 20, 2026

Summary

  • Preserve text_elements through custom prompt argument parsing and expansion (named and numeric placeholders).
  • Translate text element ranges through Shlex parsing using sentinel substitution, and rehydrate text + element ranges per arg.
  • Drop image attachments when their placeholder does not survive prompt expansion, keeping attachments consistent with rendered elements.
  • Mirror changes in TUI2 and expand tests for prompt parsing/expansion edge cases.

Tests

  • placeholders with spaces as single tokens (positional + key=value, quoted + unquoted),
  • prompt expansion with image placeholders,
  • large paste + image arg combinations,
  • unused image arg dropped after expansion.

@charley-oai charley-oai changed the base branch from main to tui-text-elements-history January 20, 2026 06:13
@charley-oai charley-oai force-pushed the tui-text-elements-history branch from 1329889 to f96ab1f Compare January 20, 2026 06:39
@charley-oai charley-oai force-pushed the prompt-expansion-text-elements branch 2 times, most recently from 1befc37 to 56eef80 Compare January 20, 2026 07:38
Base automatically changed from tui-text-elements-history to main January 20, 2026 07:49
@charley-oai charley-oai force-pushed the prompt-expansion-text-elements branch from 56eef80 to 0d8f212 Compare January 20, 2026 08:09
@aibrahim-oai
Copy link
Collaborator

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c996179481

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Collaborator Author

@codex review this

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28d5b12eb7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai force-pushed the prompt-expansion-text-elements branch from 28d5b12 to 3d0d991 Compare January 20, 2026 23:04
@charley-oai
Copy link
Collaborator Author

@codex review this

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f04f25b999

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Collaborator Author

@codex review this

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f0a21b2e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai merged commit 531748a into main Jan 21, 2026
29 of 32 checks passed
@charley-oai charley-oai deleted the prompt-expansion-text-elements branch January 21, 2026 02:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants