feat: add skill injected counter metric #9575
Merged
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
xl-openai
reviewed
Jan 21, 2026
codex-rs/core/src/codex.rs
Outdated
| } = build_skill_injections(&input, skills_outcome.as_ref()).await; | ||
|
|
||
| if injected_ok > 0 { | ||
| otel_manager.counter( |
Collaborator
There was a problem hiding this comment.
Let's keep these logic within injection.rs. Also include the skill name as a tag.
xl-openai
approved these changes
Jan 21, 2026
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
|
cc: @jif-oai start with adding a quick client side metrics first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.