fix: Fix tilde expansion to avoid absolute-path escape #9621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
~//or~///etcfrom expanding to arbitrary absolute paths (e.g./) becausePath::joindiscards the left side when the right side is absolute, which could allow config values to escapeHOMEand broaden writable roots.Description
codex-rs/utils/absolute-path/src/lib.rsupdatemaybe_expand_home_directoryto trim leading separators from the suffix and returnhomewhen the remainder is empty so tilde expansion stays rooted underHOME.home_directory_double_slash_on_non_windows_is_expanded_in_deserializationthat validates"~//code"expands tohome.join("code").Testing
just fmtsuccessfully.just fix -p codex-utils-absolute-path(Clippy autofix) successfully.cargo test -p codex-utils-absolute-pathand all tests passed.Codex Task