Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion codex-rs/otel/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ pub struct OtelEventMetadata {
pub(crate) auth_mode: Option<String>,
pub(crate) account_id: Option<String>,
pub(crate) account_email: Option<String>,
pub(crate) session_source: String,
pub(crate) model: String,
pub(crate) slug: String,
pub(crate) log_user_prompts: bool,
Expand Down Expand Up @@ -149,8 +150,13 @@ impl OtelManager {
if !self.metrics_use_metadata_tags {
return Ok(Vec::new());
}
let mut tags = Vec::with_capacity(5);
let mut tags = Vec::with_capacity(6);
Self::push_metadata_tag(&mut tags, "auth_mode", self.metadata.auth_mode.as_deref())?;
Self::push_metadata_tag(
&mut tags,
"session_source",
Some(self.metadata.session_source.as_str()),
)?;
Self::push_metadata_tag(&mut tags, "model", Some(self.metadata.model.as_str()))?;
Self::push_metadata_tag(&mut tags, "app.version", Some(self.metadata.app_version))?;
Ok(tags)
Expand Down
3 changes: 2 additions & 1 deletion codex-rs/otel/src/traces/otel_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,15 @@ impl OtelManager {
auth_mode: Option<AuthMode>,
log_user_prompts: bool,
terminal_type: String,
_session_source: SessionSource,
session_source: SessionSource,
) -> OtelManager {
Self {
metadata: OtelEventMetadata {
conversation_id,
auth_mode: auth_mode.map(|m| m.to_string()),
account_id,
account_email,
session_source: session_source.to_string(),
model: model.to_owned(),
slug: slug.to_owned(),
log_user_prompts,
Expand Down
1 change: 1 addition & 0 deletions codex-rs/otel/tests/suite/manager_metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ fn manager_attaches_metadata_tags_to_metrics() -> Result<()> {
("auth_mode".to_string(), AuthMode::ApiKey.to_string()),
("model".to_string(), "gpt-5.1".to_string()),
("service".to_string(), "codex-cli".to_string()),
("session_source".to_string(), "cli".to_string()),
("source".to_string(), "tui".to_string()),
]);
assert_eq!(attrs, expected);
Expand Down
Loading