Raise welcome animation breakpoint to 37 rows #9778
Merged
+41
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
MIN_ANIMATION_HEIGHTfrom20to37incodex-rs/tui/src/onboarding/welcome.rsso the animation is skipped unless there is enough vertical space.row_containinghelper and assert the welcome row equals the frame height plus the spacer line (frame_lines + 1).welcome_skips_animation_below_height_breakpointthat verifies the animation is not rendered when the viewport height is one row below the breakpoint.Testing
~/.cargo/bin/just fmtwhich completed successfully.cargo test -p codex-tui --liband they passed (unit test suite succeeded).cargo test -p codex-tuiwhich reported a failing integration test in this environment because the test cannot locate thecodexbinary, so full crate tests are blocked here (environment limitation).Codex Task