Skip to content

Conversation

@gt-oai
Copy link
Contributor

@gt-oai gt-oai commented Jan 23, 2026

I've seen this test fail with:

 - Mock #1.
        	Expected range of matching incoming requests: == 2
        	Number of matched incoming requests: 1

This is because we pop the wrong task_complete events and then the test exits. I think this is because the MCP events are now buffered after #8874.

So:

  1. clear the buffer before we do any user message sending
  2. additionally listen for task start before task complete
  3. use the ID from task start to find the correct task complete event.

@gt-oai gt-oai marked this pull request as draft January 23, 2026 19:35
@gt-oai gt-oai changed the title Fix flakey windows test Fix flakey conversation flow test Jan 26, 2026
@gt-oai gt-oai marked this pull request as ready for review January 26, 2026 14:25
@gt-oai gt-oai merged commit 48aeb67 into main Jan 26, 2026
32 checks passed
@gt-oai gt-oai deleted the gt/flakey-windows-test branch January 26, 2026 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants