Feat: add isOther to question returned by request user input tool #9890
Conversation
|
Let's have it on question level and tell the model to not provide an other option |
shijie-oai
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5331715ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let options_schema = JsonSchema::Array { | ||
| description: Some( | ||
| "Optional 2-3 mutually exclusive choices. Put the recommended option first and suffix its label with \"(Recommended)\". Only include \"Other\" option if we want to include a free form option. If the question is free form in nature, please do not have any option." | ||
| "Optional 2-3 mutually exclusive choices. Put the recommended option first and suffix its label with \"(Recommended)\". Do not include an \"Other\" option in this list; use isOther on the question to request a free form choice. If the question is free form in nature, please do not have any option." |
There was a problem hiding this comment.
This schema text now instructs the model to omit an explicit “Other” option and rely on isOther, but a repo-wide search (rg "is_other|isOther" codex-rs -n) shows is_other is only plumbed through structs/tests and not used to synthesize or render an “Other” choice. In the current TUI flow, freeform input for option questions is tied to a selected option, so when the model follows this new guidance (isOther: true but no “Other” option), users lose the ability to select a freeform “Other” answer and any notes will be attached to a different option instead.
Useful? React with 👍 / 👎.
shijie-oai
force-pushed
the
shijie/add-isother-to-option
branch
from
d533171 to
a1ca019
Compare
Summary
Add
isOtherto question object from request_user_input tool input and removeotheroption from the tool prompt to better handle tool input.