fix: release Python GIL during CPU intensive operations#111
Open
Gnoale wants to merge 1 commit intoopenai:mainfrom
Open
fix: release Python GIL during CPU intensive operations#111Gnoale wants to merge 1 commit intoopenai:mainfrom
Gnoale wants to merge 1 commit intoopenai:mainfrom
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
Fixes #110 to release the Python GIL and avoid deadlocks in servers using asyncio like vLLM
I validated the fix on a base v0.17.0 vLLM docker image, using the
make_asynchelper to make render_for_completion async _make_request_with_harmony