-
Notifications
You must be signed in to change notification settings - Fork 497
fix(agents-core): ensure handoff messages use valid JSON #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d63ae15
fix(core): reference schema version constant
whoiskatrin 6309ad4
Merge pull request #1 from whoiskatrin/codex/find-and-fix-bug-in-code…
whoiskatrin 0f3a85b
chore(core): add changeset for schema version fix
whoiskatrin e427085
Merge pull request #2 from whoiskatrin/add-pnpm-changeset-for-patch-u…
whoiskatrin 9055e25
Merge pull request #3 from whoiskatrin/add-pnpm-changeset-for-patch-u…
whoiskatrin 270f6b4
Merge branch 'openai:main' into main
whoiskatrin 9f06a00
Merge branch 'openai:main' into fix/invalid-json-in-transfer-message
whoiskatrin fa8b0c1
changeset: fix invalid JSON in getTransferMessage
whoiskatrin e3bb872
fix(agents-core): ensure handoff messages use valid JSON
whoiskatrin a2a85d6
Merge pull request #4 from whoiskatrin/fix/invalid-json-in-transfer-m…
whoiskatrin 35ce3fd
Delete .changeset/fix-schema-version-serialization.md
whoiskatrin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@openai/agents-core': patch | ||
| --- | ||
|
|
||
| ensure getTransferMessage returns valid JSON |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason why we went with this string is to align with Python SDK. As long as the standard JSON format works without any issues here, I think it should be fine to change this. @dkundel-openai thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine to change