Skip to content

Conversation

@rahilvora
Copy link

This PR add example on how to server agents over HTTP using FastAPI.
This solve questions
Screenshot 2025-03-14 at 3 00 12 PM

"typing-extensions>=4.12.2, <5",
"requests>=2.0, <3",
"types-requests>=2.0, <3",
"fastapi (>=0.115.11,<0.116.0)",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be a dev dependency?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 And update uv.lock, not add a poetry.lock file.

@adiberk
Copy link

adiberk commented Jun 22, 2025

I don't mind - but why is something like this necessary? It doesn't add any new information about agents themselves and how to use them. It ultimately just shows how to run a route in fastapi and returning the result - which there are many docs explaining how to do (ie., fastapi docs).

Now something that could be helpful might be showing how you can do streaming effectively with fastapi? (Maybe that exists already?). As maybe that could be a bit more involved?

@seratch seratch added the documentation Improvements or additions to documentation label Jun 25, 2025
@seratch
Copy link
Member

seratch commented Aug 1, 2025

We don't need this example for now, so let us close this PR. Thanks again for taking the time to send this!

@seratch seratch closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants