fix: use ResponseOutputRefusal for refusal content part added event #2013
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the refusal handling branch, the `ResponseContentPartAddedEvent` was incorrectly using `ResponseOutputText` as the `part` payload. This violates the OpenAI Agents protocol, which requires refusal content to be represented by `ResponseOutputRefusal` so that downstream consumers can access the `.refusal` field. This change updates the `part` field to use `ResponseOutputRefusal(refusal="", type="refusal")`, ensuring type consistency with both the accumulated state and the corresponding `ResponseContentPartDoneEvent`. Additionally, the `output_index` calculation is slightly improved for clarity by explicitly using `(1 if state.reasoning_content_index_and_output else 0)` instead of a boolean expression, though the primary fix is the payload type correction. This is a safe, minimal, and high-impact fix that aligns the stream handler with the official response schema.
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
seratch
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the refusal handling branch, the
ResponseContentPartAddedEventwas incorrectly usingResponseOutputTextas thepartpayload.This violates the OpenAI Agents protocol, which requires refusal content to be represented by
ResponseOutputRefusalso that downstream consumers can access the.refusalfield.This change updates the
partfield to useResponseOutputRefusal(refusal="", type="refusal"), ensuring type consistency with both the accumulated state and the correspondingResponseContentPartDoneEvent.Additionally, the
output_indexcalculation is slightly improved for clarity by explicitly using(1 if state.reasoning_content_index_and_output else 0)instead of a boolean expression, though the primary fix is the payload type correction.