fix: #2204 Convert tool execution exception to runtime error #2243
+16
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Overall this looks good to me. Can you resolve the CI errors? |
seratch
changed the title
Contributor
Author
|
As far as i see, there was a linter error for unused import and i fixed it and pushed. The error in |
seratch
changed the title
Contributor
Author
|
Sorry about the unit tests, it is fixed now. First time opening a PR in the repo, and other failed tests in the suite confuse it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2204 the issue I opened a while ago.
This fix changes "exception raise" to "runtime error message trigger" when an unregistered tool is triggered to be executed by the real-time model.