fix: #2540 reattach resumed traces without duplicate trace starts#2547
Merged
fix: #2540 reattach resumed traces without duplicate trace starts#2547
Conversation
github-actions
bot
added
bug
Member
Author
|
@codex review again |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e351d9a65e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #2540 by reattaching resumed
RunStatetraces instead of emitting a second top-level trace start when the sametrace_idhas already been started in the current process.The change adds a resumed-trace path in the tracing runtime so interrupted HITL runs continue under the original trace context for both
Runner.run()andRunner.run_streamed(), while preserving the existing behavior for fresh runs, explicit outerwith trace()scopes, and resumes whose trace ID has not been seen in the current process.It also adds regression coverage for interrupted non-streaming runs, interrupted streaming runs, and the low-level reattachment lifecycle to ensure resumed spans keep the original
trace_idwithout duplicatingon_trace_start/on_trace_end.