Merged
Conversation
ec2648d to
99540b9
Compare
99540b9 to
fa442d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release readiness review (v0.10.1 -> TARGET fa442d9)
This is a release readiness report done by
$final-release-reviewskill.Diff
v0.10.1...fa442d9
Release call:
🟢 GREEN LIGHT TO SHIP Additive fixes and behavior tightening with no confirmed regressions in diff review.
Scope summary:
Risk assessment (ordered by impact):
Callable MCP approval policy now requires approval when agent is omitted
Risk: 🟡 MODERATE. Tool calls that previously proceeded without approval may now block awaiting approval when
agentis not provided, affecting integrations relying on dynamic policies.Evidence:
MCPServer._needs_approvalreturnsTruewhen policy is callable andagentisNone;MCPUtil.to_function_toolclarifies behavior change.Files:
src/agents/mcp/server.py,src/agents/mcp/util.py,tests/mcp/test_mcp_util.py.Action: Run
uv run pytest -k mcp_utiland verify callable-policy tools require approval whenagent=None, while static policies remain unchanged; pass when tests green and behavior matches docs.RunState schema bump with new serialized field
Risk: 🟡 MODERATE. New
RunStateschema version1.4andrequest_idpersistence may break downgrade flows (older SDKs cannot read newer snapshots by design).Evidence:
CURRENT_SCHEMA_VERSIONchanged to1.4and serialized model responses now includerequest_id.Files:
src/agents/run_state.py,tests/test_run_state.py.Action: Run
uv run pytest -k run_stateand confirm serialized outputs includerequest_idand supported schema versions still deserialize; pass when tests green.Streaming responses now wrap and attach request IDs
Risk: 🟢 LOW. Wrapper adds cleanup and request ID propagation; risk is limited to streaming lifecycle handling if custom clients lack
with_streaming_response.Evidence:
_ResponseStreamWithRequestIdwrapper and fallback path for clients withoutwith_streaming_response.Files:
src/agents/models/openai_responses.py,src/agents/run_internal/run_loop.py,tests/test_openai_responses.py,tests/test_agent_runner_streamed.py.Action: Run
uv run pytest -k openai_responsesanduv run pytest -k agent_runner_streamed; pass when request IDs appear on terminal streamed responses and streams close cleanly.Notes: