fix: preserve title and description in ToolCallItem.to_input_item() #2777
fix: preserve title and description in ToolCallItem.to_input_item() #2777k1eran wants to merge 1 commit intoopenai:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e88b687b5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
k1eran
force-pushed
the
fix/tool-call-item-session-metadata
branch
from
0e88b68 to
4c63357
Compare
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
hmm, the typecheck and test errors need to be resolved
|
I think the current typecheck and test failures may be a sign that this fix is landing a bit too high in the stack. ToolCallItem.to_input_item() looks like it is used for normal replay/model input too, not just session persistence, so adding title / description here seems to change regular tool-call payloads as well. That would also line up with the new description: "" diffs and the typed input-item errors. Maybe the safer fix is to preserve this metadata in the session path while keeping the shared input shape unchanged. |
|
Yeah, you're right. I am exploring an alternative on my end. |
3 participants
Fixes #2776