fix: #2783 depend on griffelib directly for docstring parsing#2791
Merged
fix: #2783 depend on griffelib directly for docstring parsing#2791
Conversation
github-actions
bot
added
bug
Ha, good catch, I'll fix that 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #2783 intermittent import conflicts around Griffe by switching the SDK's published runtime dependency from
griffe1.x togriffelib2.x. The issue is that both distributions provide thegriffemodule, so mixing them in one environment can produce install-order-dependent breakage even though the SDK only needs the library functionality for docstring parsing.The change updates the package metadata to depend on
griffelib>=2,<3, refreshes the lockfile. Becausegriffelibcurrently exposes thegriffemodule without typing markers, this pull request also adds a scopedmypyignore on the import inagents.function_schemato keep type checking green without widening ignores elsewhere.No user-facing runtime API changes are intended; this is a packaging and tooling fix to make dependency resolution more robust.