fix: #2873 preserve computer driver compatibility for modifier keys#2877
Merged
fix: #2873 preserve computer driver compatibility for modifier keys#2877
Conversation
seratch
force-pushed
the
fix/computer-modifier-keys-compat
branch
2 times, most recently
from
a76e7db to
66e4819
Compare
Member
Author
|
@codex review again |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66e4819177
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seratch
force-pushed
the
fix/computer-modifier-keys-compat
branch
from
66e4819 to
83a0e58
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #2873.
This pull request fixes compatibility regressions in computer modifier-key handling for computer actions. OpenAI's computer-use actions can include optional modifier keys on mouse actions, but adding
keysto the abstractComputerandAsyncComputermethod signatures broke released subclass implementations and made legacy drivers fail at runtime when the model emitted modifier-bearing actions.The change keeps the public driver override contract intact and moves modifier-key support into runtime dispatch. Mouse-action modifiers are forwarded only when a driver method accepts
keysor generic keyword arguments, while legacy drivers continue to run with a warning when modifiers are dropped. The built-in computer-use example now holds and releases modifier keys around mouse actions, and the test suite covers compatibility across legacy, modifier-aware, async,**kwargs, and batched-action paths.