Merged
Conversation
Member
|
@codex review now |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
seratch
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the OpenAI tracing exporter to align usage metadata with the trace ingest payload shape.
For the default OpenAI tracing endpoint, usage metadata is now only included on generation spans, where it is normalized to the supported token-count shape. Other tracing endpoints continue to receive the raw SDK payload.
Adds regression coverage for OpenAI endpoint sanitization and custom endpoint behavior.
Test plan
make formatmake lintmake sync && make typecheckuv run pytest tests/test_openai_responses.py::test_get_response_span_exports_usage tests/test_trace_processor.py(46 passed)Runner.run(...)completed,flush_traces()completed, and no tracing client errors were emitted.make testsreached 3858 passed, 10 failed locally in sandbox tests becausesandbox-execreturnedsandbox_apply: Operation not permitted.Issue number
N/A
Checks
make lintandmake format