Skip to content

fix: Trust filesystem permissions for Vercel roots#2910

Merged
alfozan merged 2 commits intoopenai:mainfrom
scotttrinh:scotttrinh/vercel-root-permissions
Apr 17, 2026
Merged

fix: Trust filesystem permissions for Vercel roots#2910
alfozan merged 2 commits intoopenai:mainfrom
scotttrinh:scotttrinh/vercel-root-permissions

Conversation

@scotttrinh
Copy link
Copy Markdown
Contributor

Instead of trying to constraint the agent to only work in the workspace, allow it to fail freely without sudo.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eea081ce87

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/agents/extensions/sandbox/vercel/sandbox.py
@alfozan alfozan self-requested a review April 16, 2026 22:57
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a73c6e5176

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/agents/extensions/sandbox/vercel/sandbox.py Outdated
@seratch seratch added this to the 0.14.x milestone Apr 17, 2026
Allowing arbitrary absolute manifest roots means Vercel can no longer assume
manifest.root already exists before startup runs commands with it as cwd.

Bootstrapping the root in _prepare_backend_workspace() avoids start-time
failures for fresh writable paths and matches the workspace setup pattern
used by the other sandbox providers.
@alfozan alfozan force-pushed the scotttrinh/vercel-root-permissions branch from a73c6e5 to f5b5e33 Compare April 17, 2026 03:28
@alfozan alfozan merged commit b58d059 into openai:main Apr 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants