fix: #2951 warn for tool name character replacement#2953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #2951
transform_string_function_styleso tool names that require character replacement, such as spaces or punctuation, emit the existing warning while preserving the current lowercase normalization behavior.The previous implementation replaced spaces before comparing the transformed name, so names like
"My Tool"silently became"my_tool"without warning. This update compares the post-replacement name against the original input before lowercasing, which keeps case-only normalization such as"MyTool"->"mytool"quiet and avoids warning noise for valid letters.