refactor: share sandbox tar exclude arg generation#2987
Merged
Conversation
qiyaoq-oai
reviewed
Apr 21, 2026
| @@ -0,0 +1,18 @@ | |||
| from __future__ import annotations | |||
Contributor
There was a problem hiding this comment.
nit: we prob should have a utils lib to keep these
qiyaoq-oai
approved these changes
Apr 21, 2026
alfozan
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves sandbox workspace persistence internals by sharing the shell
tar --excludeargument generation used by Blaxel, Daytona, and E2B sandbox sessions.It adds a small common helper under
src/agents/sandbox/session/and keeps each provider's existing private_tar_exclude_args()surface as a thin delegate, preserving the generated command strings while removing duplicated quoting, sorting, and path-normalization logic. Direct unit coverage was added for empty/dot paths, stable sorting, shell quoting, dot-prefixed patterns, and absolute-path normalization.